LH data in permanent storage#11
Merged
Merged
Conversation
ataffanel
requested changes
Jun 24, 2026
ataffanel
left a comment
ataffanel
left a comment
Member
There was a problem hiding this comment.
Looks good! A couple of error management that might need tightening.
ataffanel
reviewed
Jun 25, 2026
ataffanel
approved these changes
Jun 25, 2026
ataffanel
left a comment
ataffanel
left a comment
Member
There was a problem hiding this comment.
Thanks for the updates!
I think one thing should still be fixed in this PR: the docs now contradict the new behavior of config write (see inline comment).
Otherwise, this is good to go for me!
ataffanel
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cfcli lh config writeonly wrote geometry and calibration data to RAM. It never sent the persist-data packet, so the uploaded lighthouse configuration was silently lost on the next reboot.Also, the write only touched the basestation IDs present in the input YAML file, leaving any previously-uploaded basestation data not in the file stale and still marked valid.